Support dynamic template name in partial #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change to support dynamic template name in partial for @i18n helper e.g. {>"{dynamic_template}"/}
|
Does this have a backward compatibility issue? I see you are bumping the 2nd digit. If so, what is the issue? |
|
@rragan We planned on batching this commit with some bigger changes. If you disagree, we can just bump the 3rd digit instead for this commit. |
|
No, problem. Just wanted to make sure there was no hidden incompatibility in this particular change. |
| // templateName can be static (string) or dynamic (function) | ||
| // e.g. {>"static_template"/} | ||
| // {>"{dynamic_template}"/} | ||
| if (elem) { |
There was a problem hiding this comment.
Can you add a unit test for this in test/jasmine-test/spec/coreTests.js
There was a problem hiding this comment.
Ignore this comment, that unit test already exists.
prashn64
added a commit
that referenced
this pull request
Oct 25, 2013
Support dynamic template names for the context's template name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. {>"{dynamic_template}"/}