Set up dev flow with grunt and fix coverage report #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }, | ||
| connect: { | ||
| testServer: { | ||
| options: { | ||
| port: 3000, | ||
| keepalive: true | ||
| keepalive: false |
There was a problem hiding this comment.
What does this change do?
There was a problem hiding this comment.
keepalive: true keeps test server running until ctrl + c. But it also does not allow to run any tasks after grunt connect:testServer. Since I want to start the server and then watch files for changes I need keepalive to be false.
Here are docs for this config https://github.com/gruntjs/grunt-contrib-connect#keepalive
|
Looks good minor note above. |
|
lgtm. @jimmyhchan can you take one last look and pull in? |
jimmyhchan
added a commit
that referenced
this pull request
Jun 11, 2014
Set up dev flow with grunt and fix coverage report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grunt devtask.grunt coveragetask to allow running it independently fromgrunt test.grunt teststill generates coverage report and makes sure that coverage thresholds are met (will fail otherwise)