-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to pegJS 0.8 #497
Upgrade to pegJS 0.8 #497
Conversation
@ctotheameron this is relevant to your interests when it goes in. |
Nice! This looks good to me! |
Mind-blowingly awesome if this lands. |
Awesome. Looks backcompatible everywhere. let's patch this to 2.4 2.3 and 2.2 Thanks! |
Added backcompat patch branches and merged them into the feature branch. We'll still need to npm publish, but it's as easy as checking out the proper tag. |
Upstream changes that affect us: - line and column variables are now functions - parser.toSource() removed in favor of a generator option that switches between an object and string versions
dd59179
to
c89383a
Compare
As per discussion today, threw out the 2.2 backcompat and left only 2.3. |
Upgrade to pegJS 0.8 - This change corresponds to a 90% reduction in template compile time.
Featuring an approximately 90% reduction in template compile time. Zomg-we're-faster-than-Handlebars. All tests pass. Node 0.8 compatible.
Upstream changes that affect us: