Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pegJS 0.8 #497

Merged
merged 6 commits into from
Sep 9, 2014
Merged

Upgrade to pegJS 0.8 #497

merged 6 commits into from
Sep 9, 2014

Conversation

sethkinast
Copy link
Contributor

Featuring an approximately 90% reduction in template compile time. Zomg-we're-faster-than-Handlebars. All tests pass. Node 0.8 compatible.

pegjs-0.7$ time bin/dustc ~/Desktop/syntax.md.txt > /dev/null

real    0m1.119s
user    0m1.100s
sys 0m0.024s

pegjs-0.8$ time bin/dustc ~/Desktop/syntax.md.txt > /dev/null

real    0m0.114s
user    0m0.096s
sys 0m0.017s

Upstream changes that affect us:

  • line and column variables are now functions
  • parser.toSource() removed in favor of a generator option that switches between an object and string versions

This was referenced Sep 5, 2014
@sethkinast
Copy link
Contributor Author

@ctotheameron this is relevant to your interests when it goes in.

@kate2753
Copy link
Contributor

kate2753 commented Sep 5, 2014

Nice! This looks good to me!

@shakyShane
Copy link

Mind-blowingly awesome if this lands.

@jimmyhchan
Copy link
Contributor

Awesome. Looks backcompatible everywhere. let's patch this to 2.4 2.3 and 2.2

Thanks!

@sethkinast
Copy link
Contributor Author

Added backcompat patch branches and merged them into the feature branch.

We'll still need to npm publish, but it's as easy as checking out the proper tag.

Seth Kinast added 6 commits September 9, 2014 15:31
Upstream changes that affect us:
 - line and column variables are now functions
 - parser.toSource() removed in favor of a generator option that switches between an object and string versions
@sethkinast
Copy link
Contributor Author

As per discussion today, threw out the 2.2 backcompat and left only 2.3.

prashn64 added a commit that referenced this pull request Sep 9, 2014
Upgrade to pegJS 0.8
- This change corresponds to a 90% reduction in template compile time.
@prashn64 prashn64 merged commit f5b4bc9 into linkedin:master Sep 9, 2014
@sethkinast sethkinast deleted the pegjs-0.8 branch September 9, 2014 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants