Don't instaevaluate generated body_ functions. #513
Conversation
| @@ -181,7 +181,7 @@ | |||
|
|
|||
| for (i=0, len=bodies.length; i<len; i++) { | |||
| out[i] = 'function body_' + i + '(chk,ctx){' + | |||
| blx + 'return chk' + bodies[i] + ';}'; | |||
| blx + 'return chk' + bodies[i] + ';}body_' + i + '.internal=true;'; | |||
There was a problem hiding this comment.
we use to (pre 2.4) have an isFunction check... perhaps it never worked as intended.... Anyways, this is much nicer since it's on the compiled object and not in the run time ctx object.
Now that we're in compile time, is it possible (perhaps overkill, might make it slower) to make body functions smarter. Instead of named functions can these be instances of a Bodies class. I was never a fan of how block was implemented, the strange relationship with elem and never liked the fragile calls to body(chk,ctx). This is a pretty big change but some benefits: the implementation stays in dust and not in the compiler (DRYer no need to repeat .internal), more extensible if we need to add additional properties, calls to body will be replace with body.render() which will always to defined , potentially allows some cleanup to distinguish elem, block, body_0 etc.
There was a problem hiding this comment.
Comment makes sense, I think we should open an feature issue on it. I can see how it could make things a lot less fragile, especially because I'm basically poor-man's-classing these functions already.
|
see comment above but 👍 since this address the issue cleanly |
sethkinast
force-pushed
the
no-eval-bodies
branch
2 times, most recently
from
8f917c5
to
d0efda4
Compare
| @@ -181,7 +181,7 @@ | |||
|
|
|||
| for (i=0, len=bodies.length; i<len; i++) { | |||
| out[i] = 'function body_' + i + '(chk,ctx){' + | |||
| blx + 'return chk' + bodies[i] + ';}'; | |||
| blx + 'return chk' + bodies[i] + ';}body_' + i + '.__dust=!0;'; | |||
There was a problem hiding this comment.
Can you make this .__dustBody
…to the context and attempt to render their containing block. Closes linkedin#512.
sethkinast
force-pushed
the
no-eval-bodies
branch
from
d0efda4
to
31309dc
Compare
Treat compiled body functions as blocks to render instead of functions to evaluate. Dust body functions are now flagged with .___dustBody to differentiate them from functions set in the context.
Instead, place them into the context and attempt to render their containing block.
Closes #512.