Escape template names #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is similar to #422 I think I would prefer to use our builtin function Is there a test case you can add to show the failure? Thanks! |
|
Yeah, I can do that! I was not aware of |
aredridel
force-pushed
the
escape-template-names-properly
branch
from
46b0207
to
4f292a0
Compare
|
Updated, using |
|
Nice, thanks for the test! 👍 from me; please do a rebase and squash if you would before I pull. |
Since the compiler was not interpreting template names when emitting javascript code with those as literals, and instead merely concatenating string delimiters onto the end, template names ending in a backslash or containing a newline or double quotes would cause a parser failure when loading the compiled template. This additionally escapes the null character, as some browsers will omit it during parsing, making the template name not make a round-trip from what was specified to what is cached.
aredridel
force-pushed
the
escape-template-names-properly
branch
from
4f292a0
to
f7da460
Compare
|
One commit now rather than two. |
|
lgtm |
sethkinast
added a commit
that referenced
this pull request
Feb 13, 2015
Escape template names in case they contain non-JS-safe characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the compiler was not interpreting template names when emitting
javascript code with those as literals, and instead merely concatenating
string delimiters onto the end, template names ending in a backslash
or containing a newline or double quotes would cause a parser failure
when loading the compiled template.
This additionally escapes the null character, as some browsers will omit
it during parsing, making the template name not make a round-trip from
what was specified to what is cached.