Fix the output of format (whitespace-only) blocks inside inline partials #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -233,7 +233,7 @@ | |||
| }, | |||
|
|
|||
| format: function(context, node) { | |||
| return '.w(' + escape(node[1] + node[2]) + ')'; | |||
| return '.w(' + escape(node[1]) + ')'; | |||
There was a problem hiding this comment.
I really hate that our parser gives us things like node[0] and node[1] instead of node.body and node.lineNo. Tornado...
There was a problem hiding this comment.
it's done for perf... (supposedly)
|
Looks good to me. |
|
looks good + 1 |
…als. When whitespace compression is on, format blocks are optimized away. When whitespace compression is off, format blocks are usually coerced into buffers. But if there are no buffers (which is basically only possible within an inline partial, since you're not going to compile a template that's a bunch of newlines and nothing else), we visit `compiler.nodes.format`, which didn't get updated as part of linkedin#531 since it's such an edge case. Closes linkedin#556
prashn64
added a commit
that referenced
this pull request
Mar 11, 2015
Fix the output of format (whitespace-only) blocks inside inline partials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #556