Refactor main Dust module's global context #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| })((function(){return this;})()); |
There was a problem hiding this comment.
I've tried to fix this so many times...This was for console.log according to blame (99b5ced).
There was a problem hiding this comment.
Yep, it should be 100% fixed now. I explain above why we were doing this-- it made things work by getting a windowlike, but we just shouldn't have used root.console to begin with because root should only be for the browser.
sethkinast
force-pushed
the
thisthisthis
branch
2 times, most recently
from
eda360a
to
93280c9
Compare
added 3 commits
March 24, 2015 15:47
Uses the same UMD pattern as parser and compiler now, instead of a slightly different one. `root` should only be used to refer to the browser window, not Node's `global`, so now we use `console` directly instead of `root.console`. Fixed up tests to ensure that we call dust.log even though debugLevel is turned off to avoid spam, to make sure that we test the code path. Fixes linkedin#500 by removing the IIFE in favor of `this`. Fixes linkedin#524 by allowing DEBUG=dust to be set on the command line to turn on debugging.
sethkinast
force-pushed
the
thisthisthis
branch
from
93280c9
to
a0470b8
Compare
prashn64
added a commit
that referenced
this pull request
Mar 24, 2015
Refactor main Dust module's global context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #579, don't pull until that one is.
Uses the same UMD pattern as parser and compiler now, instead of a slightly different one.
rootshould only be used to refer to the browser window, not Node'sglobal, so now we useconsoledirectly instead ofroot.console.Fixed up tests to ensure that we call dust.log even though debugLevel is turned off to avoid spam, to make sure that we test the code path.
Fixes #500 by removing the IIFE in favor of
this.Fixes #524 by allowing DEBUG=dust to be set on the command line to turn on debugging.