Move lib/server to index #583
Conversation
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| var cli = require('cli').enable('glob', 'version'), | |||
| dust = require('../lib/server.js'), | |||
| dust = require('../index.js'), | |||
There was a problem hiding this comment.
you can drop the .js ... you can also drop the index
There was a problem hiding this comment.
I didn't want to be cute... hehe
I actually always explicitly do .js after @izs said in a blog post that he wished that the extension had never been made optional.
There was a problem hiding this comment.
being extra snarky just because this is purely a convention fix and IMO convention is to leave out the extensions.
There was a problem hiding this comment.
http://blog.izs.me/post/44149270867/why-no-directories-lib-in-node-the-less-snarky
grep "deeply regrettable"
My opinion on this is not held so strongly that I won't de-.js it if you feel really strongly on it.
There was a problem hiding this comment.
Changed them to just be '..'
|
👍 thanks! |
sethkinast
force-pushed
the
server
branch
2 times, most recently
from
a468ef2
to
1b7b77e
Compare
This is the most common Node convention. It also makes it very clear that the `index.js` file is for Node by moving it away from the `lib` directory.
This is the most common Node convention. It also makes it very clear that the
server.jsfile is for Node by moving it away from thelibdirectory.