Use the tap method in the select helper #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context: {foo : 10 , x : 10}, | ||
| expected: "foobar", | ||
| message: "Select helper works correctly using tap for lte" | ||
| }, |
There was a problem hiding this comment.
can the select helper support the same too?
can we add a unit test for it ?
| if( params && params.key){ | ||
| var key = params.key; | ||
| key = this.tap(key, chunk, context); | ||
| if( key ){ |
There was a problem hiding this comment.
tap always the returns the input back as output , if the input was not a function
so this if (key) check may be redundant
vybs
added a commit
that referenced
this pull request
Jul 4, 2012
Use the tap method in the select helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the tap method in the select helper, so eq, ltegte, lt and gt can use dynamic values.