Create a new TimedInputFormat with the time-based virtual split logic used by CreateFileMapper. This allows for future workloads to easily also have time-based mapper logic. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverhu
approved these changes
Feb 12, 2019
...eter-workload/src/main/java/com/linkedin/dynamometer/workloadgenerator/CreateFileMapper.java
Show resolved
Hide resolved
...eter-workload/src/main/java/com/linkedin/dynamometer/workloadgenerator/CreateFileMapper.java
Outdated
Show resolved
Hide resolved
… used by CreateFileMapper. This allows for future workloads to easily also have time-based mapper logic.
xkrogen
force-pushed
the
ekrogen-generic-timedinputformat
branch
from
ab5a5e5 to
785ce67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CreateFileMapperis one example of a workload in which we want X number of mappers to do some action for X minutes, but this is a generally useful workload pattern. Pull out the time-based logic so that future workloads can simply define the type of action to take, and leverage the time-based behavior ofCreateFileMapper.