-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Shipkit integration for Bintray deployment #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on https://github.com/mockito/shipkit/blob/master/docs/getting-started.md#initializing-shipkit , it sounds like there should be a version.properties
file?
Let's make sure we do a test run as described here: https://github.com/mockito/shipkit/blob/master/docs/getting-started.md#test-run
Fixed up: can't do a test yet without the requisite Github and Bintray keys. |
Have we tried uploading to the shipkit-bootstrap repo for testing as described in the ShipKit getting started docs? https://github.com/mockito/shipkit/blob/master/docs/getting-started.md#test-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set up the TravisCI repo settings to have the necessary keys. But please let's do a test push as described in the ShipKit setup before committing this.
Only took 17 tries: https://github.com/csgregorian/dynamometer/releases/tag/v0.1.17 |
Cool! Is there anything I should be aware of to prevent it from taking 17 tries on the real repository? 😄 I took a look through the files that got added: https://bintray.com/version/files/shipkit-bootstrap/bootstrap/maven/0.1.17?order=asc&sort=name&basePath=com%2Flinkedin%2Fdynamometer&tab=files |
tl;dr things that (probably) won't make a difference in CI
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's see how it goes!
Shipkit setup for Bintray deployment, requires env vars and probably some other config changes.