Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis build step and fix javadoc formatting #80

Merged
merged 3 commits into from
Feb 27, 2019

Conversation

csgregorian
Copy link
Contributor

Fixed the javadoc formatting that gradle was complaining about and added a travis step that should build the whole thing every time.

.travis.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@xkrogen xkrogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides minor suggested changes

@csgregorian csgregorian force-pushed the build-step-and-javadoc branch 6 times, most recently from 5322773 to 931bb41 Compare February 27, 2019 02:18
@csgregorian csgregorian force-pushed the build-step-and-javadoc branch 3 times, most recently from 7be697a to 1cad33c Compare February 27, 2019 17:23
@csgregorian csgregorian force-pushed the build-step-and-javadoc branch from 1cad33c to a94aff6 Compare February 27, 2019 17:27
@csgregorian
Copy link
Contributor Author

Fixed changes and modified the build script a bit further: it runs a single build job (which doesn't depend on the HADOOP_VERSION) in parallel with two testing jobs (which each run on a different HADOOP_VERSION), as none of them depend on each other.

Copy link
Collaborator

@xkrogen xkrogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @csgregorian !

@xkrogen xkrogen merged commit 752ba54 into linkedin:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants