Skip to content

Change error handling to not delete data from HDFS when hive metaStore has been updated #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2021
Merged

Change error handling to not delete data from HDFS when hive metaStore has been updated #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions ...etastore/src/main/java/org/apache/iceberg/hive/HiveMetadataPreservingTableOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,30 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
throw new RuntimeException("Interrupted during commit", e);

} finally {
if (threw) {
// if anything went wrong, clean up the uncommitted metadata file
if (threw && !metadataUpdatedSuccessfully(newMetadataLocation)) {
// if anything went wrong and meta store hasn't been updated, clean up the uncommitted metadata file
io().deleteFile(newMetadataLocation);
}
unlock(lockId);
}
}

private boolean metadataUpdatedSuccessfully(String newMetadataLocation) {
boolean metadataUpdatedSuccessfully = false;
try {
Table tbl;
boolean tableExists = metaClients.run(client -> client.tableExists(database, tableName));
if (tableExists) {
tbl = metaClients.run(client -> client.getTable(database, tableName));
if (tbl.getParameters().get(METADATA_LOCATION_PROP).equals(newMetadataLocation)) {
metadataUpdatedSuccessfully = true;
}
}
} catch (Exception e) {
// This indicate the client might be closed and we cannout make sure whether the table has been updated, so
//assume it succeeds to avoid table pointing to non-exist location
metadataUpdatedSuccessfully = true;
}
return metadataUpdatedSuccessfully;
}
}