Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependencies espicaly on Jetty. #220

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

smccauliff
Copy link
Contributor

Remove some unneeded dependencies espicaly on Jetty. Jetty is only needed for
the JolokiaService, but it will start it's on embedded webserver should someone
want to run that service.
Narrow the scope of the testng dependency.

…eded for

the JolokiaService, but it will start it's on embedded webserver should someone
want to run that service.
Narrow the scope of the testng dependency.
@smccauliff
Copy link
Contributor Author

I tested that KM still works, locally but we don't have any testing for any of the metrics systems that people have contributed. Next time someone wants to modify that code they will need to provide some kind of test we can run to ensure we have not introduced regressions.

Copy link

@gitlw gitlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewchoi5
Copy link

LGTM.

@andrewchoi5 andrewchoi5 merged commit fcb8b27 into linkedin:master Mar 2, 2020
@andrewchoi5 andrewchoi5 self-assigned this Jun 11, 2020
@andrewchoi5 andrewchoi5 added this to the Improvements milestone Jun 11, 2020
@sunnythepatel
Copy link

sunnythepatel commented Sep 28, 2021

Hi @smccauliff ,
If jetty service has been removed how and what port I can check the UI on?

Thank you

@sean-rossignol
Copy link

sean-rossignol commented Oct 11, 2022

@smccauliff @andrewchoi5 @gitlw just to confirm, seems like you removed the web gui shipped with kafka-monitor and instead are saying people can use the jolokia end points to look at the jmx metrics. Is that correct?
I'm porting our in house kafka-monitor/xinfra-monitor image to master 2.5.11 from 1.1.x and we used to stand up the xinfra-monitor web gui under a separate process. I want to confirm that this gui is no longer supported before I move remove our references to the old jetty webapp.

@zigarn zigarn mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants