ConsumeService: fix client close()
causing ConcurrentModificationExeption
#393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
_baseConsumer.close()
, outside of the thread the consumer is running in, is invalidThe exception thrown
Solution
The recommended solution1 is
consumer.wakeup();
methodKMBaseConsumer
interface_baseConsumer.close()
is moved into the thread_running.compareAndSet(true, false)
, so the runloop exitsTesting Done
Increased
thread.join(5000)
timeout as this implementation is slower to stop due to not interrupting the consumer thread.- ./gradlew test
Footnotes
KafkaConsumer.java ↩ ↩2