adding state of table before assertions for clarity

linkedin · Dec 10, 2024 · d6e14d8 · d6e14d8
1 parent f725479
commit d6e14d8
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/apps/spark-3.5/src/test/java/com/linkedin/openhouse/catalog/e2e/SparkMoRFunctionalTest.java b/apps/spark-3.5/src/test/java/com/linkedin/openhouse/catalog/e2e/SparkMoRFunctionalTest.java
@@ -127,13 +127,18 @@ public void testCompactionCanRemovePositionDeleteFiles() throws NoSuchTableExcep
 
     Table table = ops.getTable(tableName);
 
+    // state of table prior to any compaction
+    IcebergTableStats stats = ops.collectTableStats(tableName);
+    assertThat(stats.getNumPositionDeleteFiles()).isEqualTo(3L);
+    assertThat(stats.getNumCurrentSnapshotPositionDeleteFiles()).isEqualTo(3L);
+
     // first run of compaction
     RewriteDataFiles.Result result = rewriteFunc.apply(ops, table);
     Assertions.assertEquals(1, result.addedDataFilesCount());
     Assertions.assertEquals(1, result.rewrittenDataFilesCount());
 
     // this asserts the dangling delete problem, since compaction did NOT remove the final delete
-    IcebergTableStats stats = ops.collectTableStats(tableName);
+    stats = ops.collectTableStats(tableName);
     assertThat(stats.getNumPositionDeleteFiles()).isEqualTo(3L);
     assertThat(stats.getNumCurrentSnapshotPositionDeleteFiles()).isEqualTo(1L);
 
@@ -168,13 +173,18 @@ public void testCompactionCanRemoveEqualityDeleteFiles() throws NoSuchTableExcep
     writeEqDeleteRecord(table, "data", "d");
     writeEqDeleteRecord(table, "data", "c");
 
+    // state of table prior to any compaction
+    IcebergTableStats stats = ops.collectTableStats(tableName);
+    assertThat(stats.getNumEqualityDeleteFiles()).isEqualTo(3L);
+    assertThat(stats.getNumCurrentSnapshotEqualityDeleteFiles()).isEqualTo(3L);
+
     // first run of compaction
     RewriteDataFiles.Result result = rewriteFunc.apply(ops, table);
     Assertions.assertEquals(1, result.addedDataFilesCount());
     Assertions.assertEquals(1, result.rewrittenDataFilesCount());
 
     // this asserts the dangling delete problem, since compaction did NOT remove the final delete
-    IcebergTableStats stats = ops.collectTableStats(tableName);
+    stats = ops.collectTableStats(tableName);
     assertThat(stats.getNumEqualityDeleteFiles()).isEqualTo(3L);
     assertThat(stats.getNumCurrentSnapshotEqualityDeleteFiles()).isEqualTo(1L);