-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mac build issue for tracevis #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After offline chat, this looks good to me. Maybe reword the description to explain a little bit about the relationship between this version bump and commands you are going to add to the developer guide.
@@ -9,7 +9,7 @@ | |||
"jshint": "~2.1.11", | |||
"istanbul": "~0.1.44", | |||
"mocha": "1.2.x", | |||
"phantomjs": "~1.9.2-2", | |||
"phantomjs": "^2.1.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own understanding, what does ^ mean here? 2.1.7 or above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
equivalent to 2.*
~2.1.7 is 2.1.*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Thanks.
I would advise that you leave a note in the |
I think we should add a dev guide which can include this, will add this task in queue |
Upgrading phantomjs to solve one of the build issue in testCov, fails on mac only since c++ libs used to build are different on mac. Other issues relating to installation failure:
Root cause is contextify being no longer support as it is merged native to node.
Permanent fix is upgrade node and package dependencies.
for now will have use below patches(one time). I will add specific cmds to developer guide.
Refer:
nodejs/node-gyp#569
nodejs/node-gyp#469