Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PEX to 1.2.2 #110

Closed
wants to merge 1 commit into from
Closed

Upgrade PEX to 1.2.2 #110

wants to merge 1 commit into from

Conversation

dsully
Copy link

@dsully dsully commented Feb 1, 2017

No description provided.

@lorencarvalho
Copy link
Contributor

tests failing on:

Could not find compatible interpreter

This error is from pex itself, here's the block that raises it: https://github.com/pantsbuild/pex/blob/7e8faa2cd32ade42f6a4306828d44765c4f2a655/pex/bin/pex.py#L463-L494

Since we don't pass a --python arg, this line resolves the interpreter path:

interpreter = PythonInterpreter.get()

Which grabs the interpreter from sys.executable:

  @classmethod
  def get(cls):
    return cls.from_binary(sys.executable)

Really not sure why this would be failing in such a way...

@@ -62,10 +62,10 @@ class PackageInfoTest extends Specification {

def 'can parse a windows path'() {
when:
def packageInfo = PackageInfo.fromPath('Z:\\pygradle\\build\\ivy-repo\\pypi\\setuptools\\19.1.1\\setuptools-19.1.1')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs to be updated with the repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't hurt though.

@zvezdan
Copy link
Member

zvezdan commented Feb 1, 2017

Did you check if setuptools>=19.1.1 actually works with the packages and products we build internally?
I did and I can confirm it doesn't.
Why is this update needed right now?

@dsully
Copy link
Author

dsully commented Feb 1, 2017

@zvezdan - there's an incompatibility between the new version of CacheControl and pex (which also uses CacheControl).

pex-tool/pex#357

@zvezdan
Copy link
Member

zvezdan commented Jun 16, 2017

@dsully We upgraded pex, setuptools, and more in the #145 and to higher versions than this PR.
Can we close/discard this?

@dsully dsully closed this Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants