Ivy and PyPi module, file names compatibility #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the following issue:
for PiPy modules that have non-equal file and module names, ivy metafiles will be generated incorrectly.
Because when Importer generates dependencies part of ivy file, it takes module name from name field of PyPi meta but when Importer creates directories and artifact file itself, directory name and file name are created from filename field of PyPi meta, and these two configuration aspects can be different. It means that ivy cannot find files for specified dependencies.
for instance, I was trying to add
mypy
library https://pypi.org/pypi/mypy/jsonImporter created dependencies like this:
but directories and file names have been created with underscore
mypy_extensions
.In the fix, module name, directory name and file name are created from the same value of the
name
field of PyPi metafile (ex. https://pypi.org/pypi/mypy/json).