Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivy and PyPi module, file names compatibility #341

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ivy and PyPi module, file names compatibility #341

wants to merge 2 commits into from

Conversation

BrainLogic
Copy link

@BrainLogic BrainLogic commented Mar 5, 2020

Fix for the following issue:
for PiPy modules that have non-equal file and module names, ivy metafiles will be generated incorrectly.
Because when Importer generates dependencies part of ivy file, it takes module name from name field of PyPi meta but when Importer creates directories and artifact file itself, directory name and file name are created from filename field of PyPi meta, and these two configuration aspects can be different. It means that ivy cannot find files for specified dependencies.

for instance, I was trying to add mypy library https://pypi.org/pypi/mypy/json
Importer created dependencies like this:

<dependencies defaultconfmapping="*->default">
    <dependency org="pypi" name="typed-ast" rev="1.4.0" conf="default" />
    <dependency org="pypi" name="typing-extensions" rev="3.7.4" conf="default" />
    <dependency org="pypi" name="mypy-extensions" rev="0.4.3" conf="default" />
</dependencies>

but directories and file names have been created with underscore mypy_extensions.

In the fix, module name, directory name and file name are created from the same value of the name field of PyPi metafile (ex. https://pypi.org/pypi/mypy/json).

@BrainLogic
Copy link
Author

@zvezdan please help to review and merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant