Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some dual read related tests and deprecate dual read LB #1014

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Remove some dual read related tests and deprecate dual read LB #1014

merged 1 commit into from
Aug 9, 2024

Conversation

bohhyang
Copy link
Contributor

@bohhyang bohhyang commented Aug 9, 2024 •
edited
Loading

  1. Fixed a warm-up test about deleting files after shutdown.
  2. Some dual read related tests for WarmUpLoadBalancer has been flaky. Since dual read will be deprecated soon, disable these tests to smooth the release.
  3. As we get close to complete INDIS migration, marking dual read LB as deprecated to note that no new reference to it should be created anymore.

brycezhongqing
brycezhongqing approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@brycezhongqing brycezhongqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bohhyang bohhyang merged commit 3227d01 into master Aug 9, 2024
2 checks passed
@bohhyang bohhyang deleted the by/cleanTests branch August 9, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycezhongqing brycezhongqing brycezhongqing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bohhyang @brycezhongqing