Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove three unused and deprecated configurations. #641

Merged
merged 5 commits into from
Dec 2, 2021
Merged

Remove three unused and deprecated configurations. #641

merged 5 commits into from
Dec 2, 2021

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Jun 17, 2021

The "dataTemplateGenerator", "restTools", and "avroSchemaGenerator"
configurations have been deprecated and are now unused.

This is backwards incompatible, so we can wait until the next major version
release, although it is in my opinion low risk to roll out even now.

The "dataTemplateGenerator", "restTools", and "avroSchemaGenerator"
configurations have been deprecated and are now unused.
@evanw555 evanw555 added the backward-incompatible Changes/removes an existing API, requires major version bump. PRs with this label should be bundled. label Jun 23, 2021
Copy link
Contributor

@evanw555 evanw555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the one nit comment. Although this is likely to not break anyone, I'd still suggest bundling this with a major version.

CHANGELOG.md Show resolved Hide resolved
@evanw555 evanw555 added the v30 Should be bundled with the version 30.0.0 release label Oct 27, 2021
@nickibi nickibi changed the base branch from master to release/v30 December 2, 2021 22:41
@nickibi nickibi merged commit fb68fa5 into linkedin:release/v30 Dec 2, 2021
evanw555 pushed a commit that referenced this pull request Dec 3, 2021
The "dataTemplateGenerator", "restTools", and "avroSchemaGenerator"
configurations have been deprecated and are now unused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-incompatible Changes/removes an existing API, requires major version bump. PRs with this label should be bundled. v30 Should be bundled with the version 30.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants