Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avro1.9.2 upgrade #735

Merged
merged 13 commits into from
Dec 2, 2021
Merged

Avro1.9.2 upgrade #735

merged 13 commits into from
Dec 2, 2021

Conversation

junchuanwang
Copy link
Contributor

@junchuanwang junchuanwang commented Nov 30, 2021 •
edited
Loading

Removed avro adaptor 1.4/1.6

Upgraded avro to 1.9.2 and fixed tests and SchemaTranslator logic

As a by-product, Jackson versions also upgraded to 2.10.2

@junchuanwang junchuanwang added v30 Should be bundled with the version 30.0.0 release backward-incompatible Changes/removes an existing API, requires major version bump. PRs with this label should be bundled. labels Dec 1, 2021
@junchuanwang junchuanwang changed the title [WIP] Avro1.9.2 upgrade Avro1.9.2 upgrade Dec 1, 2021
radai-rosenblatt
radai-rosenblatt approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@radai-rosenblatt radai-rosenblatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits

nickibi
nickibi approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@nickibi nickibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits, otherwise LGTM

@nickibi nickibi changed the base branch from master to release/v30 December 2, 2021 23:24
@nickibi nickibi changed the base branch from release/v30 to master December 2, 2021 23:24
@nickibi nickibi changed the base branch from master to release/v30 December 2, 2021 23:25
@nickibi nickibi merged commit d9f23e6 into release/v30 Dec 2, 2021
@nickibi nickibi deleted the avro1.9.2Upgrade branch December 2, 2021 23:25
evanw555 pushed a commit that referenced this pull request Dec 3, 2021
@junchuanwang @evanw555
Avro1.9.2 upgrade (#735)
e224ad3 
Remove avro1.4 adapter and avro1.6 related modules.
Upgrade dependency on Avro to 1.9.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radai-rosenblatt radai-rosenblatt radai-rosenblatt approved these changes

@nickibi nickibi nickibi approved these changes

@evanw555 evanw555 Awaiting requested review from evanw555

@aman1309 aman1309 Awaiting requested review from aman1309

Assignees
No one assigned
Labels
backward-incompatible Changes/removes an existing API, requires major version bump. PRs with this label should be bundled. v30 Should be bundled with the version 30.0.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@junchuanwang @radai-rosenblatt @nickibi @evanw555