address review comments

linkedin · Dec 4, 2024 · db06d6e · db06d6e
1 parent 5feda4e
commit db06d6e
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/...ices/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java b/...ices/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java
@@ -3532,15 +3532,16 @@ private boolean hasFatalDataValidationError(PushMonitor pushMonitor, String topi
   }
 
   private void safeDeleteRTTopic(String clusterName, String storeName) {
-    if (isRTTopicDeletionPermittedByAllControllers(clusterName, storeName)) {
+    boolean rtDeletionPermitted = isRTTopicDeletionPermittedByAllControllers(clusterName, storeName);
+    if (rtDeletionPermitted) {
       String rtTopicToDelete = Version.composeRealTimeTopic(storeName);
       deleteRTTopicFromAllFabrics(rtTopicToDelete, clusterName);
-    }
-    // Check if there is incremental push topic exist. If yes, delete it and send out to let other controller to
-    // delete it.
-    String incrementalPushRTTopicToDelete = Version.composeSeparateRealTimeTopic(storeName);
-    if (getTopicManager().containsTopic(pubSubTopicRepository.getTopic(incrementalPushRTTopicToDelete))) {
-      deleteRTTopicFromAllFabrics(incrementalPushRTTopicToDelete, clusterName);
+      // Check if there is incremental push topic exist. If yes, delete it and send out to let other controller to
+      // delete it.
+      String incrementalPushRTTopicToDelete = Version.composeSeparateRealTimeTopic(storeName);
+      if (getTopicManager().containsTopic(pubSubTopicRepository.getTopic(incrementalPushRTTopicToDelete))) {
+        deleteRTTopicFromAllFabrics(incrementalPushRTTopicToDelete, clusterName);
+      }
     }
   }