[compat][server][client][test] Global RT DIV improvement (part 2): Chunking support for DIV message #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusong64
reviewed
Oct 23, 2024
...ts/da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTask.java
Outdated
Show resolved
Hide resolved
lusong64
reviewed
Oct 23, 2024
...ts/da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTask.java
Outdated
Show resolved
Hide resolved
lusong64
reviewed
Oct 23, 2024
lusong64
reviewed
Oct 23, 2024
...a-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTaskTest.java
Outdated
Show resolved
Hide resolved
sixpluszero
changed the title
sixpluszero
reviewed
Nov 7, 2024
internal/venice-common/src/main/resources/avro/GlobalDivState/v-15/GlobalDivState.avsc
Show resolved
Hide resolved
clients/da-vinci-client/src/main/java/com/linkedin/davinci/utils/ChunkAssembler.java
Show resolved
Hide resolved
...ts/da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTask.java
Show resolved
Hide resolved
...ient/src/main/java/com/linkedin/davinci/kafka/consumer/LeaderFollowerStoreIngestionTask.java
Show resolved
Hide resolved
…unking support for DIV message
This change mainly focuses on adding chunking support for DIV messages when they are produced to Kafka topics,
as the size of DIV message can be large. We leverage today's chunking mechanism for regular records and extend
it to support DIV with the following modifications:
1. All the DIV messages are of type {@link MessageType#CONTROL_MESSAGE_DIV} in its KafkaKey and their corresponding
KafkaMessageEnvelope uses Put as the payload.
2. Inside the Put payload, the actual message is stored in the putValue field and the schemaId can have the following cases:
- If the DIV message is non-chunked, the schemaId is set to GLOBAL_DIV_STATE.
- If the DIV message is chunk message, the schemaId is set to CHUNK.
- If the DIV message is a chunk manifest message, the schemaId is set to CHUNKED_VALUE_MANIFEST.
3. ChunkAssembler is adapted, on the receiver side, to buffer, assemble, and deserialize DIV messages (chunked/non-chunked).
lluwm
force-pushed
the
rt_div_heartbeat
branch
from
1aa1844 to
88d1d2d
Compare
KaiSernLim
reviewed
Dec 6, 2024
internal/venice-common/src/main/java/com/linkedin/venice/writer/WriterChunkingHelper.java
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/kafka/protocol/enums/MessageType.java
Show resolved
Hide resolved
...nice-common/src/main/java/com/linkedin/venice/serialization/avro/AvroProtocolDefinition.java
Show resolved
Hide resolved
internal/venice-common/src/test/java/com/linkedin/venice/writer/VeniceWriterUnitTest.java
Show resolved
Hide resolved
Comment on lines
+458
to
+459
| this.divChunkAssembler = | ||
| builder.getDivChunkAssembler() != null ? builder.getDivChunkAssembler() : new ChunkAssembler(storeName); |
There was a problem hiding this comment.
Suggested change
| this.divChunkAssembler = | |
| builder.getDivChunkAssembler() != null ? builder.getDivChunkAssembler() : new ChunkAssembler(storeName); |
nit: Can this be achieved by just reusing chunkAssembler? They seem the same to me, other than the unit test access via builder?
There was a problem hiding this comment.
Could internal ChunkAssembler.inMemoryStorageEngine have a conflict if use the same instance?
There was a problem hiding this comment.
It's not impossible, but I think a conflict is improbable if the key is something very specific
.../venice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/TestGlobalDiv.java
Show resolved
Hide resolved
.../venice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/TestGlobalDiv.java
Show resolved
Hide resolved
.../venice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/TestGlobalDiv.java
Show resolved
Hide resolved
.../venice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/TestGlobalDiv.java
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/writer/VeniceWriter.java
Show resolved
Hide resolved
|
Continuing the PR in #1385. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change mainly focuses on adding chunking support for DIV messages when they are produced to Kafka topics, as the size of DIV message can be large. We leverage today's chunking mechanism for regular records and extend it to support DIV with the following modifications:
How was this PR tested?
Does this PR introduce any user-facing changes?