[server] Ingestion Debugging Improvement by making logging more informative. #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoxu07
force-pushed
the
hybrid_quota_test
branch
from
554406f
to
3d6bca3
Compare
haoxu07
force-pushed
the
hybrid_quota_test
branch
from
3d6bca3
to
03c970a
Compare
haoxu07
changed the title
haoxu07
changed the title
huangminchn
reviewed
Dec 2, 2024
| StringBuilder sb = new StringBuilder(); | ||
| for (Map.Entry<PubSubTopicPartition, TopicPartitionIngestionInfo> entry: topicPartitionIngestionInfoMap | ||
| .entrySet()) { | ||
| sb.append(entry.getKey().toString()).append(": ").append(entry.getValue().toString()).append("\n"); |
There was a problem hiding this comment.
BTW, how big this log could be for a multi-tenant cluster? And how often would this log be printed?
There was a problem hiding this comment.
This is controller by:
(!REDUNDANT_LOGGING_FILTER.isRedundantException(slowestTaskIdString)) {
Once per minute.
lusong64
reviewed
Dec 2, 2024
| Map<PubSubTopicPartition, TopicPartitionIngestionInfo> topicPartitionIngestionInfoMap = | ||
| getIngestionInfoFromConsumer(consumer); | ||
| // Convert Map of ingestion info for this consumer to String for logging with each partition line by line | ||
| StringBuilder sb = new StringBuilder(); |
There was a problem hiding this comment.
Nowaday's JVM can easily optimize string concatenate by simply using a stringBuilder for you. So String concatenation is not a sin anymore.
Not an issue. Just an FYI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary, imperative, start upper case, don't end with a period
How was this PR tested?
Does this PR introduce any user-facing changes?