-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server][dvc] Add Blob Transfer Related Metrics #1352
[server][dvc] Add Blob Transfer Related Metrics #1352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks ok, left one comment and will need to fix the coverage issue. and also synced offline, we agreed that due to the short period of blob transfer in some cases, it is ok to use gauge to set the throughput and count for other metrics, otherwise it may get averaged out or missed.
clients/da-vinci-client/src/main/java/com/linkedin/davinci/blobtransfer/BlobTransferUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
[server][dvc] Add Blob Transfer Related Metrics
This PR introduces 5 metrics to track blob transfer activity as a client side:
As a client side:
How was this PR tested?
Testing with private build at testing hosts.
Does this PR introduce any user-facing changes?