Revert "[compat] [controller] add rt topic name in store config (#1345)" #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisargthakkar
requested changes
Dec 2, 2024
internal/venice-common/src/main/resources/avro/StoreMetaValue/v26/StoreMetaValue.avsc
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/resources/avro/StoreMetaValue/v27/StoreMetaValue.avsc
Outdated
Show resolved
Hide resolved
services/venice-controller/src/main/resources/avro/AdminOperation/v83/AdminOperation.avsc
Outdated
Show resolved
Hide resolved
services/venice-controller/src/main/resources/avro/AdminOperation/v84/AdminOperation.avsc
Outdated
Show resolved
Hide resolved
arjun4084346
force-pushed
the
revertRealTimeTopicName
branch
from
9ac595c
to
9da0f5d
Compare
…edin#1345)" This reverts commit cc6e3db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a commit that throws NPE
This reverts commit cc6e3db. PR #1345
because that commits throws NPE
Caused by: java.lang.NullPointerException: Cannot invoke "java.lang.CharSequence.toString()" because "this.hybridConfig.realTimeTopicName" is null at com.linkedin.venice.meta.HybridStoreConfigImpl.getRealTimeTopicName(HybridStoreConfigImpl.java:108) ~[com.linkedin.venice.venice-common-0.4.368.jar:?] at com.linkedin.venice.meta.HybridStoreConfigImpl.clone(HybridStoreConfigImpl.java:146) ~[com.linkedin.venice.venice-common-0.4.368.jar:?] at com.linkedin.venice.meta.ZKStore.<init>(ZKStore.java:186) ~[com.linkedin.venice.venice-common-0.4.368.jar:?] at com.linkedin.venice.meta.ZKStore.cloneStore(ZKStore.java:969) ~[com.linkedin.venice.venice-common-0.4.368.jar:?] at com.linkedin.venice.helix.HelixReadWriteStoreRepository.lambda$getAllStores$0(HelixReadWriteStoreRepository.java:96) ~[com.linkedin.venice.venice-common-0.4.368.jar:?] at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?] at java.util.concurrent.ConcurrentHashMap$ValueSpliterator.forEachRemaining(ConcurrentHashMap.java:3612) ~[?:?] at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?] at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?] at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?] at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?] at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?] at com.linkedin.venice.helix.HelixReadWriteStoreRepository.getAllStores(HelixReadWriteStoreRepository.java:96) ~[com.linkedin.venice.venice-common-0.4.368.jar:?] at com.linkedin.venice.helix.HelixReadOnlyStoreRepositoryAdapter.getAllStores(HelixReadOnlyStoreRepositoryAdapter.java:127) ~[com.linkedin.venice.venice-common-0.4.368.jar:?] at com.linkedin.venice.controller.HelixVeniceClusterResources.repairStoreReplicationFactor(HelixVeniceClusterResources.java:215) ~[com.linkedin.venice.venice-controller-0.4.368.jar:?] at com.linkedin.venice.controller.HelixVeniceClusterResources.refresh(HelixVeniceClusterResources.java:244) ~[com.linkedin.venice.venice-controller-0.4.368.jar:?] at com.linkedin.venice.controller.VeniceControllerStateModel.initClusterResources(VeniceControllerStateModel.java:195) ~[com.linkedin.venice.venice-controller-0.4.368.jar:?] at com.linkedin.venice.controller.VeniceControllerStateModel.lambda$onBecomeLeaderFromStandby$0(VeniceControllerStateModel.java:150) ~[com.linkedin.venice.venice-controller-0.4.368.jar:?] at com.linkedin.venice.controller.VeniceControllerStateModel.executeStateTransition(VeniceControllerStateModel.java:111) ~[com.linkedin.venice.venice-controller-0.4.368.jar:?] at com.linkedin.venice.controller.VeniceControllerStateModel.onBecomeLeaderFromStandby(VeniceControllerStateModel.java:129) ~[com.linkedin.venice.venice-controller-0.4.368.jar:?] ... 12 moreResolves #XXX
How was this PR tested?
Does this PR introduce any user-facing changes?