Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): arm64 support #45

Closed

Conversation

the-wondersmith
Copy link

@the-wondersmith the-wondersmith commented Apr 30, 2024

PR adds multi-arch / arm64 support to the linkerd dev tooling stack.


Notes

There are a few stages that should be FROM apt-base as {stage name} but have been changed to FROM docker.io/library/rust:alpine as {stage name} (effectively). This is because the upstream sources these stages are pulling binaries from do not supply arm64 binaries. Luckily though, they're all rust codebases, so cargo install --git='repo url' --tag='existing version tag argument' takes care of the issue as a simple proof of concept.

The repositories in question are:

There is an open (but as-of-yet-unmerged) PR to add arm64 builds to cargo-deny's releases.
PR #659 to cargo-deny was merged 2024-05-03.

The other three repos (j5j, hokay, and cargo-action-fmt) all belong to @olix0r and so hopefully won't be as much of an ordeal to add arm64 support to 😅.

IMPORTANT: while this PR should be entirely safe to merge without the altered stages being restored to their original FROM apt-base as {stage name} forms, they do impose a non-zero but realistically negligible amount of overhead to build times. If the decision is made to have the three repos mentioned above supply multi-arch binaries of their own, the only real changes to the Dockerfile that should persist should be the additions of the sed expressions that take care of formatting upstream urls to match the platform of the build target.

Screenshots

multi-arch-tags

Signed-off-by: Mark S <the@wondersmith.dev>
Signed-off-by: Mark S <the@wondersmith.dev>
Signed-off-by: Mark S <the@wondersmith.dev>
Signed-off-by: Mark S <the@wondersmith.dev>
Signed-off-by: Mark S <the@wondersmith.dev>
Signed-off-by: Mark S <the@wondersmith.dev>
Signed-off-by: Mark S <the@wondersmith.dev>
Signed-off-by: Mark S <the@wondersmith.dev>
@the-wondersmith the-wondersmith marked this pull request as ready for review May 16, 2024 21:36
@the-wondersmith
Copy link
Author

Closing this to get it off my list of open PRs, and because it doesn't seem like there's any interest in it outside of @kflynn 🫤. Please feel free to re-open it at your discretion though 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant