Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds multi-arch / arm64 support to the linkerd dev tooling stack.
Notes
There are a few stages that should be
FROM apt-base as {stage name}
but have been changed toFROM docker.io/library/rust:alpine as {stage name}
(effectively). This is because the upstream sources these stages are pulling binaries from do not supplyarm64
binaries. Luckily though, they're all rust codebases, socargo install --git='repo url' --tag='existing version tag argument'
takes care of the issue as a simple proof of concept.The repositories in question are:
cargo-denyThere is an open (but as-of-yet-unmerged) PR to addarm64
builds tocargo-deny
's releases.PR #659 to
cargo-deny
was merged 2024-05-03.The other three repos (
j5j
,hokay
, andcargo-action-fmt
) all belong to @olix0r and so hopefully won't be as much of an ordeal to addarm64
support to 😅.Screenshots