Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about running in minikube, fix port conflict #109

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

klingerf
Copy link
Member

@klingerf klingerf commented Mar 9, 2017

I wrote up some instructions about running the k8s-daemonset examples on Minikube, and added them to the README. I ran into one issue with a port conflict in the hello svc config, and I think our example apps were actually misconfigured, so I've changed the configuration to work in (hopefully) all envs. Relates to #45.

Copy link
Contributor

@rmars rmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍵

Copy link
Contributor

@esbie esbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! lgtm

@klingerf klingerf merged commit 6d9f581 into master Mar 9, 2017
@klingerf klingerf deleted the kl/minikube branch March 9, 2017 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants