feat(destination): add resource metadata to responses

The destination service does no include resource coordinates, so the proxy must "guess" them by parsing hostnames, which is not particularly reliable or efficient. This change updates the destination API so that profile responses may include resource reference to (1) parent Services, (2) ServiceProfile resources and (3) backend Services. Furthermore, the WeightedAddr type is updated to include a resource reference so that Pod coordinates may be referenced. This metadata is not required to be set (for backwards compatibility).
linkerd · Nov 5, 2024 · 07e8269 · 07e8269
1 parent c5648ae
commit 07e8269
Show file tree

Hide file tree

Showing 18 changed files with 343 additions and 251 deletions.
diff --git a/go/destination/destination.pb.go b/go/destination/destination.pb.go
diff --git a/go/destination/destination_grpc.pb.go b/go/destination/destination_grpc.pb.go
diff --git a/go/grpc_route/grpc_route.pb.go b/go/grpc_route/grpc_route.pb.go
diff --git a/go/http_route/http_route.pb.go b/go/http_route/http_route.pb.go
diff --git a/go/http_types/http_types.pb.go b/go/http_types/http_types.pb.go
diff --git a/go/identity/identity.pb.go b/go/identity/identity.pb.go
diff --git a/go/identity/identity_grpc.pb.go b/go/identity/identity_grpc.pb.go
diff --git a/go/inbound/inbound.pb.go b/go/inbound/inbound.pb.go
diff --git a/go/inbound/inbound_grpc.pb.go b/go/inbound/inbound_grpc.pb.go
diff --git a/go/meta/meta.pb.go b/go/meta/meta.pb.go
diff --git a/go/net/net.pb.go b/go/net/net.pb.go
diff --git a/go/outbound/outbound.pb.go b/go/outbound/outbound.pb.go
diff --git a/go/outbound/outbound_grpc.pb.go b/go/outbound/outbound_grpc.pb.go
diff --git a/go/tap/tap.pb.go b/go/tap/tap.pb.go
diff --git a/go/tap/tap_grpc.pb.go b/go/tap/tap_grpc.pb.go
diff --git a/go/tls_route/tls_route.pb.go b/go/tls_route/tls_route.pb.go
diff --git a/proto/destination.proto b/proto/destination.proto
@@ -7,6 +7,7 @@ option go_package = "github.com/linkerd/linkerd2-proxy-api/go/destination";
 import "google/protobuf/duration.proto";
 
 import "http_types.proto";
+import "meta.proto";
 import "net.proto";
 
 /// Destination Service ///
@@ -107,6 +108,10 @@ message WeightedAddr {
   // is HTTP/2 or when the H2 ProtocolHint is used to transport HTTP/1
   // connections over HTTP/2.
   Http2ClientParams http2 = 8;
+
+  // A reference to the metadata for this endpoint, usually a Pod. This may be
+  // omitted when the resource type is unknown.
+  meta.Metadata resource_ref = 9;
 }
 
 message TlsIdentity {
@@ -255,6 +260,14 @@ message DestinationProfile {
   //
   // No endpoint should be set If the target is unknown.
   WeightedAddr endpoint = 6;
+
+  // A reference to the metadata for this destination, usually a service. May be
+  // omitted if the destination is not a service.
+  meta.Metadata parent_ref = 7;
+
+  // A reference to the metadata for a ServiceProfile resource. This is omitted
+  // when no ServiceProfile resource exists.
+  meta.Metadata profile_ref = 8;
 }
 
 message Route {
@@ -348,4 +361,6 @@ message WeightedDst {
   // The proportion of requests to send to this destination.  This value is
   // relative to other weights in the same dst_overrides list.
   uint32 weight = 2;
+  // A reference to the metadata for a Service resource.
+  meta.Metadata backend_ref = 3;
 }
diff --git a/src/gen/io.linkerd.proxy.destination.rs b/src/gen/io.linkerd.proxy.destination.rs