-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wall clock gauge to proxy metrics #3176
Conversation
Signed-off-by: Scott Fleener <scott@buoyant.io>
192c2df
to
307a256
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3176 +/- ##
==========================================
+ Coverage 67.68% 68.22% +0.54%
==========================================
Files 332 353 +21
Lines 15158 16551 +1393
==========================================
+ Hits 10259 11292 +1033
- Misses 4899 5259 +360
... and 37 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Scott Fleener <scott@buoyant.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 🌮 🌮
Currently, it's not possible to accurately calculate the time remaining before the proxy certificate expires, since the proxy didn't expose its view of what the time is. This exposes the wall clock time (rounded to the nearest second) as a gauge so downstream consumers can calculate the offsets for cert expiry, as well as any other offsets for timestamps we provide.
Example metrics output:
Fixes #12413