Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy log level should not be order-dependent #4138

Closed
olix0r opened this issue Mar 5, 2020 · 2 comments · Fixed by linkerd/linkerd2-proxy#455
Closed

proxy log level should not be order-dependent #4138

olix0r opened this issue Mar 5, 2020 · 2 comments · Fixed by linkerd/linkerd2-proxy#455
Assignees
@hawkw
Labels
priority/P0 Release Blocker

Comments

@olix0r
Copy link
Member

olix0r commented Mar 5, 2020

A proxy log level like linkerd=debug,warn does not emit any logs, but warn,linkerd=debug seems to work as intended. This is surprising and, I think, a regression from previous behavior. I would expect it to work as longest-match-wins, ignoring order.
@olix0r olix0r added the priority/P0 Release Blocker label Mar 5, 2020
@hawkw
Copy link
Contributor

hawkw commented Mar 5, 2020

Yup, that's definitely a bug. I'll take a look.

@hawkw hawkw mentioned this issue Mar 5, 2020
Closed
@hawkw
Copy link
Contributor

hawkw commented Mar 5, 2020

should be fixed upstream by tokio-rs/tracing#624

hawkw added a commit to linkerd/linkerd2-proxy that referenced this issue Mar 5, 2020
@hawkw
trace: update tracing-subscriber to 0.2.3
3c29bfa 
This picks up tokio-rs/tracing#624, which fixes linkerd/linkerd2#4138.

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw mentioned this issue Mar 5, 2020
Merged
hawkw added a commit to linkerd/linkerd2-proxy that referenced this issue Mar 6, 2020
@hawkw
trace: update tracing-subscriber to 0.2.3 (#455)
1cc1a81 
This picks up tokio-rs/tracing#624, which fixes linkerd/linkerd2#4138.

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hawkw hawkw

Labels
priority/P0 Release Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

trace: update tracing-subscriber to 0.2.3 linkerd/linkerd2-proxy
2 participants
@olix0r @hawkw