proxy can error due to HTTP/2 stream resets

[olix0r]

As described in hyperium/h2#256, it's possible for some stream resets to cause h2 to panic. This is very likely to impact the proxy. @carllerche @seanmonstar

[seeekr]

I'm seeing something like this:

conduit_proxy turning Error caused by underlying HTTP/2 error: protocol error: unexpected internal error encountered into 500

when I just terminate my HTTP server that conduit is proxying for, while processing a response and not having written anything to it yet.

Is this related? Sounds like it could be. Or should I file a separate issue for that?

[seanmonstar]

@seeekr no, that would be different. A panic in the proxy will in most cases make it crash, not report a 500 error.

As to your issue... you're killing an HTTP server mid-response? Seems like the proxy seeing that and returning 500 is correct.

[seeekr]

Thanks @seanmonstar. If that's what it's doing then that is acceptable behavior. Just wasn't sure if this indicated a problem on conduit's part which I should look into understanding, since I was overall seeing some weird behavior in terms of connectivity for my service. (Killing it mid-response was not great, of course, and I've since changed that to be a little more graceful.)

Keep up the good work! 👍

[olix0r]

hyperium/h2#258 will fix this. We learned that the conduit proxy will not panic in these situations, as it is built in release-mode. Panics are limited to debug builds.

[siggy]

Fixed in hyperium/h2#258. @olix0r please re-open if this is still an issue.

[carllerche]

I would leave this open for now. There still is one known issue. Relates to hyperium/h2#261 and hyperium/h2#259.

[carllerche]

I have squashed many bugs. There is still some work I would like to get done, then I will release a new crate.

Please ping me if this is not closed by next release.

[olix0r]

h2-0.1.7 fixes a whole slew of state management corner-cases