Build conduit-specific Grafana Docker image #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
approved these changes
Apr 5, 2018
| @@ -0,0 +1,11 @@ | |||
| apiVersion: 1 | |||
There was a problem hiding this comment.
Is this only used for development?
Can you add a comment to this file describing what it's for, preferably with a reference to some source of truth for its format? (Guessing it's http://docs.grafana.org/v5.0/administration/provisioning/#dashboards)
There was a problem hiding this comment.
Yup, only for development. I've added a comment and referenced the Grafana docs.
Using a vanilla Grafana Docker image as part of `conduit install` avoided maintaining a conduit-specific Grafana Docker image, but made packaging dashboard json files cumbersome. Roll our own Grafana Docker image, that includes conduit-specific dashboard json files. This significantly decreases the `conduit install` output size, and enables dashboard integration in the docker-compose environment. Fixes #567 Part of #420 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy
force-pushed
the
siggy/roll-your-grafana
branch
from
575253a to
d82211f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a vanilla Grafana Docker image as part of
conduit installavoided maintaining a conduit-specific Grafana Docker image, but made
packaging dashboard json files cumbersome.
Roll our own Grafana Docker image, that includes conduit-specific
dashboard json files. This significantly decreases the
conduit installoutput size, and enables dashboard integration in the docker-compose
environment.
Fixes #567
Part of #420
Signed-off-by: Andrew Seigner siggy@buoyant.io