Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose pod stats in CLI, web UI, and Grafana #788

Merged
merged 3 commits into from
Apr 18, 2018
Merged

Expose pod stats in CLI, web UI, and Grafana #788

merged 3 commits into from
Apr 18, 2018

Conversation

klingerf
Copy link
Contributor

This branch updates the CLI, web UI, and Grafana to add pod stat support.

CLI:

$ bin/conduit stat pods -n emojivoto
NAME                        MESHED   SUCCESS      RPS   LATENCY_P50   LATENCY_P95   LATENCY_P99
emoji-75b75b7c69-brkl9         1/1   100.00%   8.0rps           1ms           1ms           2ms
vote-bot-698df677b9-bspdf      1/1         -        -             -             -             -
voting-7548d57c9f-d6zpz        1/1    75.83%   4.0rps           1ms           2ms           3ms
web-584f848c8c-2bv7l           1/1    89.79%   8.0rps           3ms           5ms           9ms

Web:

image

Grafana:

image

Fixes #504.

Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
@klingerf klingerf added this to the 0.4.1 milestone Apr 18, 2018
@klingerf klingerf self-assigned this Apr 18, 2018
@klingerf klingerf requested a review from siggy April 18, 2018 00:10
@siggy
Copy link
Member

siggy commented Apr 18, 2018

this should get you past ci:

diff --git a/web/app/test/ApiHelpersTest.jsx b/web/app/test/ApiHelpersTest.jsx
index 122a3d0..f8e03a3 100644
--- a/web/app/test/ApiHelpersTest.jsx
+++ b/web/app/test/ApiHelpersTest.jsx
@@ -285,7 +285,7 @@ describe('ApiHelpers', () => {
     it('returns the correct rollup url for deployment overviews', () => {
       api = ApiHelpers('/go/my/own/way');
       let deploymentUrls = api.urlsForResource["deployment"].url("myNamespace", "myDeploy");
-      expect(deploymentUrls.rollup).to.equal('/api/stat?resource_type=deployment&namespace=myNamespace&resource_name=myDeploy');
+      expect(deploymentUrls.rollup).to.equal('/api/stat?resource_type=deployment');
     });
   });
 });

Copy link
Member

@siggy siggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli, web, and grafana all look awesome! all comments non-blocking, once it passes ci, 🚢

curious: why no Outbound Traffic row on the grafana dashboard?

# Get all namespaces.
conduit stat --all-namespaces=true namespaces`,
conduit stat namespaces
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -0,0 +1,105 @@
import _ from 'lodash';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this review, down the road we should look at DRYing up this file with DeploymentsList.jsx

return (
<this.props.conduitLink
to={`/dashboard/db/conduit-deployment?var-namespace=${namespace}&var-deployment=${deployment}`}
to={`/dashboard/db/conduit-${this.props.resource}?var-namespace=${namespace}&var-${this.props.resource}=${name}`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@klingerf
Copy link
Contributor Author

why no Outbound Traffic row on the grafana dashboard?

Ahhh, good catch -- that was an oversight by me. Will add it in a follow-up commit on this branch.

Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
@klingerf klingerf merged commit 71a51af into master Apr 18, 2018
@klingerf klingerf removed the review label Apr 18, 2018
@klingerf klingerf deleted the kl/pods branch April 18, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants