-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose pod stats in CLI, web UI, and Grafana #788
Conversation
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
this should get you past ci: diff --git a/web/app/test/ApiHelpersTest.jsx b/web/app/test/ApiHelpersTest.jsx
index 122a3d0..f8e03a3 100644
--- a/web/app/test/ApiHelpersTest.jsx
+++ b/web/app/test/ApiHelpersTest.jsx
@@ -285,7 +285,7 @@ describe('ApiHelpers', () => {
it('returns the correct rollup url for deployment overviews', () => {
api = ApiHelpers('/go/my/own/way');
let deploymentUrls = api.urlsForResource["deployment"].url("myNamespace", "myDeploy");
- expect(deploymentUrls.rollup).to.equal('/api/stat?resource_type=deployment&namespace=myNamespace&resource_name=myDeploy');
+ expect(deploymentUrls.rollup).to.equal('/api/stat?resource_type=deployment');
});
});
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cli, web, and grafana all look awesome! all comments non-blocking, once it passes ci, 🚢
curious: why no Outbound Traffic
row on the grafana dashboard?
# Get all namespaces. | ||
conduit stat --all-namespaces=true namespaces`, | ||
conduit stat namespaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -0,0 +1,105 @@ | |||
import _ from 'lodash'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not for this review, down the road we should look at DRYing up this file with DeploymentsList.jsx
return ( | ||
<this.props.conduitLink | ||
to={`/dashboard/db/conduit-deployment?var-namespace=${namespace}&var-deployment=${deployment}`} | ||
to={`/dashboard/db/conduit-${this.props.resource}?var-namespace=${namespace}&var-${this.props.resource}=${name}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Ahhh, good catch -- that was an oversight by me. Will add it in a follow-up commit on this branch. |
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
This branch updates the CLI, web UI, and Grafana to add pod stat support.
CLI:
Web:
Grafana:
Fixes #504.