Add contributing doc and DCO file #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
klingerf
force-pushed
the
kl/contributing
branch
from
23bc6f1 to
c26d5da
Compare
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
pcalcado
pushed a commit
that referenced
this pull request
Dec 27, 2017
* Add contributing doc and DCO file Signed-off-by: Kevin Lingerfelt <kl@buoyant.io> * Fix small typos Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
pcalcado
pushed a commit
that referenced
this pull request
Dec 27, 2017
* Add contributing doc and DCO file Signed-off-by: Kevin Lingerfelt <kl@buoyant.io> * Fix small typos Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
* Add contributing doc and DCO file Signed-off-by: Kevin Lingerfelt <kl@buoyant.io> * Fix small typos Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
Currently, the layered service implementations that comprise the HTTP stack are a mix of `Service` and `NewService` types. In the endpoint-specific stack. `transparency::Client` is the only layer that actually needs to be a `NewService` if it is wrapped immediately with a `Reconnect`. This allows us to remove several `NewService` implementations. This extracts a new `svc::Reconnect` middleware from `bind`, handling connection error logging and hiding `tower_reconnect::Error` from outer layers. Furthermore, two HTTP/1-specific middlewares have been moved outside of the TLS rebinding layer, since they are not dependent on TLS configuration. Finally, `bind`'s type aliases have been simplified, removing the `HttpRequest` and `HttpResponse` aliases. By removing these, and removing `transparency::Client`'s dependency on the telemetry body types, it should be easier to change type signatures going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md describes best practices for contributing to the repo. DCO contains the Developer Certificate of Origin policy, to which all contributors must agree, by signing their commits with their approval.