Adding statefulsets to inject

[grampelberg]

No description provided.

[siggy]

by convention, add Fixes #907 to the end of your commit message, that way Github will resolve the original issue when this merges.

[siggy]

you'll need to create a new k8s.ProxyStatefulSetLabel.

taking this a bit farther, this implies some subsequent tasks (best done in future PRs, not this one):

• cli stat (part of Fully-implemented, resource-aware conduit stat #627)
• cli tap
• web
• grafana

it's possible that with this particular PR, we'll at least get stateful-set labels and metrics wired all the way through from inject -> pod -> destination service -> proxy -> prometheus, but i'm not totally sure. have you tried deploying a StatefulSet and seeing if metrics show up in Prometheus?

[grampelberg]

That's just what I needed. I'll go look at those now and update this.

[grampelberg]

• prometheus - getting all the metrics
• grafana - dashboards are limited to deployments
• stat - not working for statefulset, working fine for pod
• tap - not working for statefulset, working fine for pod
• dashboard - would need statefulset added

@siggy what do you think would be the best way to move forward. I see a couple options:

• only enable injection in this PR.
• fixup stat/tap to be aware of statefulsets.
• add the resource type to the dashboard.
• make everything in conduit resource-type aware. (a superset of Fully-implemented, resource-aware conduit stat #627)

For this PR, purely from a scoping/focus perspective, it feels okay to leave it at injection and open up issues to track the others. It looks like we've missed implementing things like stat/tap for the other resource types as well (job, daemonset).

[siggy]

thanks for all the updates.

i agree most of this work should be done in subsequent PRs, and we just focus on injection for this PR.

for this PR, there are a couple more places that i think we need to add StatefulSet support:

• https://github.com/runconduit/conduit/blob/0431193e9482f488ddba16da72a724efcb14c2a8/pkg/k8s/labels.go#L63-L70
• https://github.com/runconduit/conduit/blob/0431193e9482f488ddba16da72a724efcb14c2a8/pkg/k8s/labels_test.go#L12-L31

[grampelberg]

Ah, the joys of learning a new codebase. Got that all updated, thank you!

[siggy]

looks great! i realized there are two more doc updates needed. please shipit after that:

https://github.com/runconduit/conduit/blob/76ca32297e6576e3ffe1a4b86803b9d50fc5bafa/doc/proxy-metrics.md#outbound-labels

https://github.com/runconduit/conduit/blob/76ca32297e6576e3ffe1a4b86803b9d50fc5bafa/doc/proxy-metrics.md#conduit-labels-added-at-collection-time

[grampelberg]

I grep'd for those, damnit! The underscore got me.