Add filter to remove deleted pods #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pims It certainly was. Thank you! I'm curious as to what the pod phase is in such cases, still "Running"? |
linki
reviewed
Oct 23, 2019
chaoskube/chaoskube.go
Outdated
| @@ -368,6 +369,18 @@ func filterByPhase(pods []v1.Pod, phase v1.PodPhase) []v1.Pod { | |||
| return filteredList | |||
| } | |||
|
|
|||
| // filterDeletedPods removes pod which have a non nil DeletionTimestamp | |||
| func filterDeletedPods(pods []v1.Pod) []v1.Pod { | |||
There was a problem hiding this comment.
Let's rename this to filterTerminatingPods.
linki
reviewed
Oct 23, 2019
| filtered := filterDeletedPods(pods) | ||
| suite.Equal(len(filtered), 1) | ||
| suite.Equal(pods[0].Name, "running") | ||
| } |
|
@linki yes, in this case the pode phase is still |
linki
force-pushed
the
filter-terminating-pods
branch
from
67ac04f to
2e65fa5
Compare
|
@pims Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
filterByPhasefunction:does not filter out lingering pods in "terminating state", which is not a real PodPhase, but a state computed from the presence of a
DeletionTimestamp: https://sourcegraph.com/github.com/kubernetes/kubernetes@v1.12.7/-/blob/pkg/printers/internalversion/printers.go#L640-642Any lingering pod in this state keeps on being selected by ChaosKube for termination.
If it is fair to assume that filtering by phase was meant to only select active pods and that deleted pods should not be included, this PR should address the issue.