Initial Proemtheus metrics support #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bakins you can now rebase on master |
bakins
force-pushed
the
initial-proemtheus
branch
from
657063b
to
1ea7337
Compare
|
@linki I rebased. Do you want to review this as is or would you like me to add some metrics first? Initial metrics I considered was number of runs and errors - possibly with timings on them. I wasn't sure if you wanted a different PR for those. |
|
@bakins It's fine. Thank you! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #93 which added the HTTP listener.
This adds the Prometheus metrics handler but does not record any application specific metrics. I think we may want to wait until #95 is merged before adding metrics as that PR changed the structure of how the loop is ran.
I had to "fix" the protobuf dependency to get this to work with the addition of Prometheus.