This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
support plain A record if ingress is using IP #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankon
reviewed
Feb 23, 2017
consumers/aws.go
Outdated
| //endpointsToAlias converts pkg Endpoint to route53 Alias Records | ||
| func (a *awsConsumer) endpointsToAlias(endpoints []*pkg.Endpoint) ([]*route53.ResourceRecordSet, error) { | ||
| lbDNS := make([]string, len(endpoints)) | ||
| //endpointsToRecords converts pkg Endpoint to route53 Alias Records |
There was a problem hiding this comment.
"Alias" here in the description should then also go?
There was a problem hiding this comment.
@ankon yes this WIP ;)
hjacobs
reviewed
Feb 23, 2017
consumers/aws.go
Outdated
| rset = append(rset, a.endpointToAlias(ep, aws.String(loadBalancerZoneID))) | ||
| rset = append(rset, a.endpointToRecord(ep, aws.String(loadBalancerZoneID))) | ||
| } else if ep.IP != "" { | ||
| rset = append(rset, a.endpointToRecord(ep, aws.String(""))) | ||
| } else { | ||
| log.Errorf("Canonical Zone ID for endpoint: %s is not found", ep.Hostname) |
There was a problem hiding this comment.
wording: "xy was not found"
linki
reviewed
Feb 23, 2017
consumers/aws.go
Outdated
| lbDNS := make([]string, len(endpoints)) | ||
| //endpointsToRecords converts pkg Endpoint to route53 A [Alias] Records depending whether IP/LB Hostname is used | ||
| func (a *awsConsumer) endpointsToRecords(endpoints []*pkg.Endpoint) ([]*route53.ResourceRecordSet, error) { | ||
| lbDNS := make([]string, 0) |
There was a problem hiding this comment.
if you don't filter you can set the capacity here.
|
LGTM |
tuxlife
reviewed
Feb 23, 2017
consumers/aws.go
Outdated
| for i := range endpoints { | ||
| lbDNS[i] = endpoints[i].Hostname | ||
| lbDNS = append(lbDNS, endpoints[i].Hostname) |
There was a problem hiding this comment.
Why did you use the index (i) an not the value?
for _, endpoint := range endpoints {
lbDNS = append(lbDNS, endpoint.Hostname)
}There was a problem hiding this comment.
right, left over from previous loop impl where index was a better option :)
tuxlife
reviewed
Feb 23, 2017
| @@ -103,11 +104,11 @@ func (a *awsConsumer) syncPerHostedZone(kubeRecords []*route53.ResourceRecordSet | |||
| upsertedMap := make(map[string]bool) // keep track of records to be upserted | |||
| targetMap := map[string][]*string{} // map dnsname -> list of targets | |||
| for _, kr := range kubeRecords { | |||
| targetMap[aws.StringValue(kr.Name)] = append(targetMap[aws.StringValue(kr.Name)], kr.AliasTarget.DNSName) | |||
| targetMap[aws.StringValue(kr.Name)] = append(targetMap[aws.StringValue(kr.Name)], aws.String(a.getRecordTarget(kr))) | |||
There was a problem hiding this comment.
Why did you use aws.StringValue(kr.Name) instead of *kr.Name
There was a problem hiding this comment.
safeguard if kr.Name is nil
szuecs
reviewed
Feb 23, 2017
| ep := &pkg.Endpoint{ | ||
| DNSName: "example.com", | ||
| IP: "10.202.10.123", | ||
| Hostname: "amazon.elb.com", | ||
| } | ||
| rsA := client.endpointToAlias(ep, &zoneID) | ||
| rsA := client.endpointToRecord(ep, &zoneID) |
There was a problem hiding this comment.
then the TestName should be fixed, too :)
|
if all is good, this can be merged IMO |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @linki @hjacobs @tuxlife