This repository has been archived by the owner on May 7, 2021. It is now read-only.
Support extended IDs in CantactDev.recv()
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CantactDev.recv()` was creating the `can.Frame` without specifying whether it had an extended arbitration ID or not. The default is `False`, and so the extended ID was throwing `ValueError: Arbitration ID out of range`. Signed-off-by: Scott Armitage <scott@armitage.space>
|
Hey all, any reason we can't get this pulled into |
|
I installed pyvit with "pip install pyvit", and experienced this problem. It took me a while until I found what was wrong. I did a fix, and planned committing it, but then I realized it was already fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CantactDev.recv()was creating thecan.Framewithout specifying whether it had an extended arbitration ID or not. The default isFalse, and so the extended ID was throwingValueError: Arbitration ID out of range.Signed-off-by: Scott Armitage scott@armitage.space