Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a curie type #149

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Adding a curie type #149

merged 2 commits into from
Feb 4, 2023

Conversation

cmungall
Copy link
Member

@cmungall cmungall commented Feb 3, 2023

@cmungall cmungall requested a review from hsolbrig February 3, 2023 21:50
@cmungall cmungall changed the title Adding a curie type. linkml develper call 2023-02-03 Adding a curie type Feb 3, 2023
@hsolbrig
Copy link
Contributor

hsolbrig commented Feb 3, 2023

Before we integrate this, I think we need to define the behavior of this type.

Questions:

  1. is ":x" a valid Curie? how about "x" w/o the colon.
  2. is "ex:x" a valid Curie if "ex" is not in a prefix map?
  3. I'm assuming that "https://ex.org/x" is NOT a valid curie -- is there a RE or formal spec that we should use to validate tthese

@cmungall
Copy link
Member Author

cmungall commented Feb 4, 2023

Added a conforms_to to the W3C spec.

Note we already have an implementation of this, we just made the corresponding entry in types (we have used uriorcurie for cases were we need curies)

https://github.com/linkml/linkml-runtime/blob/a8b4dd14abab2eca48cd10a99b287077fcc2c55c/linkml_runtime/utils/metamodelcore.py#L148-L188

@cmungall cmungall merged commit ceb2ad6 into main Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants