basic repo maintenance #167
Conversation
sierra-moxon
changed the title
…en authoring schemas
sierra-moxon
changed the title
sierra-moxon
changed the title
… legacy setup.py and setup.cfg
sierra-moxon
requested review from
pkalita-lbl,
sujaypatil96,
cmungall,
amc-corey-cox and
turbomam
and removed request for
amc-corey-cox,
sujaypatil96,
cmungall and
turbomam
| on: | ||
| pull_request: | ||
| branches: [ main ] | ||
| types: [ opened, synchronize, reopened ] |
There was a problem hiding this comment.
I think it's fine to explicitly specify the activity types here, but just FYI these are the default anyway:
By default, a workflow only runs when a
pull_requestevent's activity type isopened,synchronize, orreopened. To trigger workflows by different activity types, use the types keyword.
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Validate YAML file | ||
| run: yamllint -c .yamllint-config linkml_model/model/schema/*.yaml |
There was a problem hiding this comment.
How does yamllint get installed in this workflow?
There was a problem hiding this comment.
yamllint is already installed on Ubuntu-based GitHub runners.
There was a problem hiding this comment.
Whoa! actions/runner-images#1142 So it is. The more you know!
| poetry run codespell | ||
|
|
||
| lint: | ||
| poetry run yamllint -c .yamllint-config linkml_model/model/schema/*.yaml |
There was a problem hiding this comment.
What do you think about using one of the three standard config file names (.yamllint, .yamllint.yaml, or .yamllint.yml -- https://yamllint.readthedocs.io/en/stable/configuration.html) so that the -c flag doesn't have to be specified every time?
| | [subsets](subsets.md) | 0..* <br/> [SubsetDefinition](SubsetDefinition.md) | An index to the collection of all subset definitions in the schema | | ||
| | [prefixes](prefixes.md) | 0..* <br/> [Prefix](Prefix.md) | prefix / URI definitions to be added to the context beyond those fetched from... | | ||
| | [default_prefix](default_prefix.md) | 0..1 <br/> [xsd:string](http://www.w3.org/2001/XMLSchema#string) | default and base prefix -- used for ':' identifiers, @base and @vocab | | ||
| | [default_range](default_range.md) | 0..1 <br/> [TypeDefinition](TypeDefinition.md) | default slot range to be used if range element is omitted from a slot definit... | |
There was a problem hiding this comment.
This is probably tangential to your changes, but what's up with all these tables with truncated lines? Are these autogenerated from something?
|
yep, those lines are autogenerated. Maybe better just to link out.
… Message ID: ***@***.***>
|
gen-projectwhich doesmeta.yamlwith-mergeimports=False)..HTMLfiles. I removed that regex and limited it by file extension instead. I added a makefile target to run codespell locally and cleaned up the reported errors.yamllinter to the GH actions and a Makefile target to run it. The next step is using our own linkml-lint to do the equivalent level of linting for these older schemas that might take awhile to move to the new standards (e.g. Biolink, linkml-model, etc.).codespell,yamllintdev dependencies inpyproject.toml. I know there is more to do in the pyproject.toml file - I stopped short of doing the rest!setup.pyandsetup.cfgany longer. These are also removed in this PR.linkml:notesto all our Types classes to indicate on our generated doc, that we should use lowercase names for these instead of uppercase.