-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the ability to declare "prefixmaps" contexts (including bioregistry contexts) in default_curie_maps. fixes #604 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 63.28% 63.61% +0.33%
==========================================
Files 52 53 +1
Lines 6076 6126 +50
Branches 1642 1652 +10
==========================================
+ Hits 3845 3897 +52
Misses 1774 1774
+ Partials 457 455 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sierra-moxon
changed the title
add prefixmaps with modified version
add the ability to declare "prefixmaps" contexts (including bioregistry contexts) in default_prefix_maps.
Dec 20, 2022
Taking a look - is the plan to use a list of prioritized prefix contexts as fallbacks or just one context? |
in biolink-model, I want to use |
sierra-moxon
changed the title
add the ability to declare "prefixmaps" contexts (including bioregistry contexts) in default_prefix_maps.
add the ability to declare "prefixmaps" contexts (including bioregistry contexts) in default_prefix_maps. fixes #604
Dec 22, 2022
sierra-moxon
changed the title
add the ability to declare "prefixmaps" contexts (including bioregistry contexts) in default_prefix_maps. fixes #604
add the ability to declare "prefixmaps" contexts (including bioregistry contexts) in default_curie_maps. fixes #604
Dec 22, 2022
cmungall
approved these changes
Dec 23, 2022
This was referenced Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use case here is:
Incorporate prefixmaps context lookup functionality to linkml-runtime.utils.namespaces.add_prefixmap so that we can use bioregistry contexts as a fallback when none of obo_context, idot_contex, monarch_context, semweb_context, etc. contain the prefix.
somewhat related to linkml/linkml#852 - this doesn't deprecate default_prefix_maps, it just adds to the available maps that folks can use (incl. bioregistry maps).
The next step here is to allow this changed method to read a prefix map directly without the requirement that it be in prefixcommons or prefixmaps.
Hard-coding the map names here is not the best approach; I see a TODO in prefixmaps repo that those at least should be introspected from a config file (👍 ).