1126 slot modifying classes #245
Conversation
|
Along with the other PR I think this should add the functionality we need. |
|
As I mentioned in Slack. I had some issues with push this PR. As you can see with the last commit, I needed to fix an issue with the test_schemaview that was failing. We should verify this is an appropriate fix. Separately, I was not able to rebase because doing so caused pytest to fail on gather tests from
The first line can just be commented out but the second import issue is due to this file being missing from
I wasn't sure how to reconcile that so I just created this PR without rebasing on |
| @@ -702,7 +702,8 @@ def test_mergeimports(self): | |||
| "core", | |||
| "prov", | |||
| "xsd", | |||
| "shex"], | |||
| "shex", | |||
| "schema"], | |||
There was a problem hiding this comment.
you took the right approach, but ideally this situation would not have happened
There was a problem hiding this comment.
Logic that implements the retrieval of classes that modify certain slot definitions in slot_usage statements of that class looks excellent. Great work @amc-corey-cox.
| from tests.test_issues.environment import env | ||
|
|
||
|
|
||
| class Issue998TestCase(TestCase): |
There was a problem hiding this comment.
class Issue998TestCase or class Issue1126TestCase? Very trivial but just noticed it
runtime portion to implement showing classes that modify a slot on the slot page for docgen.
linkml/linkml#1126