Handle attributes edge case in schema_as_dict #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmungall
approved these changes
Aug 7, 2024
|
Hi @cmungall. Thanks for the approval. It looks like 3 of the checks failed while Poetry attempted to install a dependency. My PR doesn't touch the lock file so I was hoping this might be a transient failure, but I don't see a way to re-trigger the checks. |
cmungall
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SchemaBuilder, any slots defined with name="name", will be removed by the schema_as_dict function, if the slot was added to a class using the use_attributes=True flag.
See issue: linkml/linkml#2247