Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erdiagramgen issue where mermaid output contains enum variable name #1433

Merged
merged 1 commit into from
May 12, 2023

Conversation

nicholsn
Copy link

@nicholsn nicholsn commented May 7, 2023

This PR closes #1210 where the enum IdentifyingType.IDENTIFYING was being printed in the mermaid markdown output.

I added a __str__ method to the IdentifyingType enum so it'll render correctly.

Before

erDiagram
Dataset ||IdentifyingType.IDENTIFYING}o Distribution : "distribution"
Loading

After

erDiagram
Dataset ||--}o Distribution : "distribution"
Loading

@nicholsn nicholsn changed the title Fix erdiagramgen issue where merrmaid output contains enum variable name Fix erdiagramgen issue where mermaid output contains enum variable name May 7, 2023
@cmungall cmungall requested a review from sujaypatil96 May 8, 2023 19:12
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Merging #1433 (4aff2c4) into main (e38c90e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1433   +/-   ##
=======================================
  Coverage   80.23%   80.24%           
=======================================
  Files          78       78           
  Lines        9220     9222    +2     
  Branches     2244     2244           
=======================================
+ Hits         7398     7400    +2     
  Misses       1380     1380           
  Partials      442      442           
Impacted Files Coverage Δ
linkml/generators/erdiagramgen.py 96.07% <100.00%> (+0.05%) ⬆️

@sierra-moxon sierra-moxon merged commit f5dc934 into linkml:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error generating ER diagram using mermaid website.
4 participants