Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify getting a curies.Converter from a prefixmaps.Context #37

Merged
merged 7 commits into from
Apr 12, 2023
Merged

Simplify getting a curies.Converter from a prefixmaps.Context #37

merged 7 commits into from
Apr 12, 2023

Conversation

cthoyt
Copy link
Collaborator

@cthoyt cthoyt commented Mar 14, 2023 •
edited
Loading

This PR introduces curies as a core requirement and simplifies the usage in many examples in the README for generating a curies.Converter object from a prefixmaps.Context object down to a single line:

from prefixmaps import load_multi_context
from curies import Converter

context = load_multi_context(["obo", "bioregistry.upper", "linked_data", "prefixcc"])
converter: Converter = context.as_converter()

@cthoyt
Add direct function for getting curies.Converter
87cf5c3 
This PR introduces `curies` as a requirement and simplifies the usage in many examples in the README for generating a `curies.Converter` object from a `prefixmaps.Context` object down to a single line
@cthoyt
Add curies as requirement
98e133b
@cthoyt
Update test_curies.py
a581939
@cthoyt
Update context.py
7f5b72a
@cthoyt
Update test_curies.py
2757ec1
@cthoyt
Copy link
Collaborator Author

cthoyt commented Apr 11, 2023

@sierra-moxon now that a new release has been made, can we get this in?

@sierra-moxon sierra-moxon merged commit 02923b2 into linkml:main Apr 12, 2023
@cthoyt cthoyt deleted the faster-converter branch April 12, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sierra-moxon sierra-moxon sierra-moxon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cthoyt @sierra-moxon