Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some existing tests generate invalid schemas #141

Closed
cmungall opened this issue Jul 29, 2024 · 0 comments · Fixed by #143
Closed

Some existing tests generate invalid schemas #141

cmungall opened this issue Jul 29, 2024 · 0 comments · Fixed by #143
Assignees
@cmungall

Comments

@cmungall
Copy link
Member

This is going unnoticed (I believe) due to the fact the test doesn't try and reconstitute the generated schema via schemaloader.

E.g. tests/test_121/input/schema_def.tsv defines the name as some schema but this is not a valid NCName
@cmungall cmungall self-assigned this Jul 29, 2024
cmungall added a commit that referenced this issue Jul 30, 2024
@cmungall
Fixing test 121 to be valid.
0647b29 
Fixes #141
@cmungall cmungall mentioned this issue Jul 30, 2024
Merged
cmungall added a commit that referenced this issue Jul 30, 2024
@cmungall
Adding Property Graph example
ae5030c 
Fixes #142

Also adding roundtrip when generating schema, catches issues with #141
@cmungall cmungall mentioned this issue Jul 30, 2024
Merged
cmungall added a commit that referenced this issue Jul 30, 2024
@cmungall
Adding Property Graph example (#144)
530f303 
Fixes #142

Also adding roundtrip when generating schema, catches issues with #141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmungall cmungall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing test 121 to be valid. linkml/schemasheets
1 participant
@cmungall