Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infer some descriptor_rows from table_config #114

Merged
merged 8 commits into from
Jul 17, 2023
Merged

infer some descriptor_rows from table_config #114

merged 8 commits into from
Jul 17, 2023

Conversation

turbomam
Copy link
Contributor

@turbomam turbomam commented Jul 15, 2023 •
edited
Loading

@turbomam turbomam requested a review from cmungall July 17, 2023 16:39
cmungall
cmungall reviewed Jul 17, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
cmungall
cmungall reviewed Jul 17, 2023
View reviewed changes
schemasheets/generate_populate.py
import logging
import pkg_resources

# todo write tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea :-)

@cmungall cmungall marked this pull request as draft July 17, 2023 19:50
@turbomam turbomam requested a review from cmungall July 17, 2023 20:57
@turbomam turbomam marked this pull request as ready for review July 17, 2023 20:57
cmungall
cmungall approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge if needed but let's make sure to return to unit tests

@turbomam
Copy link
Contributor Author

turbomam commented Jul 17, 2023 •
edited
Loading

@turbomam turbomam merged commit 52c2baa into main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall cmungall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbomam @cmungall